netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, stable@vger.kernel.org,
	sashal@kernel.org
Subject: Re: [PATCH -stable,5.15 2/2] netfilter: nf_tables: unbind non-anonymous set if rule construction fails
Date: Wed, 5 Jul 2023 20:54:08 +0100	[thread overview]
Message-ID: <2023070533-swimwear-audition-49e8@gregkh> (raw)
In-Reply-To: <20230705141411.53123-3-pablo@netfilter.org>

On Wed, Jul 05, 2023 at 04:14:11PM +0200, Pablo Neira Ayuso wrote:
> [ 3e70489721b6c870252c9082c496703677240f53 ]
> 
> Otherwise a dangling reference to a rule object that is gone remains
> in the set binding list.
> 
> Fixes: 26b5a5712eb8 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
>  net/netfilter/nf_tables_api.c | 2 ++
>  1 file changed, 2 insertions(+)

But what about kernels newer than 5.15?  Surely this is also needed
there as this only is going to first show up in 6.5-rc1, which hasn't
been released yet.

thanks,

greg k-h

  reply	other threads:[~2023-07-05 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 14:14 [PATCH -stable,5.15 0/2] stable fixes for 5.15 Pablo Neira Ayuso
2023-07-05 14:14 ` [PATCH -stable,5.15 1/2] netfilter: nf_tables: drop map element references from preparation phase Pablo Neira Ayuso
2023-07-05 14:14 ` [PATCH -stable,5.15 2/2] netfilter: nf_tables: unbind non-anonymous set if rule construction fails Pablo Neira Ayuso
2023-07-05 19:54   ` Greg KH [this message]
2023-07-05 20:23     ` Florian Westphal
2023-07-05 22:56       ` Pablo Neira Ayuso
2023-07-16 15:17         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023070533-swimwear-audition-49e8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).