From: Florian Westphal <fw@strlen.de>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: pablo@netfilter.org, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, kadlec@netfilter.org, pabeni@redhat.com,
dsahern@kernel.org, fw@strlen.de, daniel@iogearbox.net,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 3/6] netfilter: bpf: Prevent defrag module unload while link active
Date: Fri, 7 Jul 2023 22:20:17 +0200 [thread overview]
Message-ID: <20230707202017.GD11622@breakpoint.cc> (raw)
In-Reply-To: <7549d65daa702ba89aa3e43d5a1bbd562d569a99.1688748455.git.dxu@dxuuu.xyz>
Daniel Xu <dxu@dxuuu.xyz> wrote:
> While in practice we could handle the module being unloaded while a
> netfilter link (that requested defrag) was active, it's a better user
> experience to prevent the defrag module from going away. It would
> violate user expectations if fragmented packets started showing up if
> some other part of the system tried to unload defrag module.
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2023-07-07 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 16:50 [PATCH bpf-next v3 0/6] Support defragmenting IPv(4|6) packets in BPF Daniel Xu
2023-07-07 16:50 ` [PATCH bpf-next v3 1/6] netfilter: defrag: Add glue hooks for enabling/disabling defrag Daniel Xu
2023-07-07 20:11 ` Florian Westphal
2023-07-07 16:50 ` [PATCH bpf-next v3 2/6] netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link Daniel Xu
2023-07-07 20:17 ` Florian Westphal
2023-07-07 16:50 ` [PATCH bpf-next v3 3/6] netfilter: bpf: Prevent defrag module unload while link active Daniel Xu
2023-07-07 20:20 ` Florian Westphal [this message]
2023-07-07 16:50 ` [PATCH bpf-next v3 4/6] bpf: selftests: Support not connecting client socket Daniel Xu
2023-07-07 16:50 ` [PATCH bpf-next v3 5/6] bpf: selftests: Support custom type and proto for client sockets Daniel Xu
2023-07-07 16:50 ` [PATCH bpf-next v3 6/6] bpf: selftests: Add defrag selftests Daniel Xu
2023-07-11 0:37 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707202017.GD11622@breakpoint.cc \
--to=fw@strlen.de \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).