From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: stable@vger.kernel.org, netfilter-devel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@lists.linux.dev, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: [PATCH 5.4 187/313] netfilter: nf_tables: unbind non-anonymous set if rule construction fails
Date: Tue, 25 Jul 2023 12:45:40 +0200 [thread overview]
Message-ID: <20230725104529.052399107@linuxfoundation.org> (raw)
In-Reply-To: <20230725104521.167250627@linuxfoundation.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
[ 3e70489721b6c870252c9082c496703677240f53 ]
Otherwise a dangling reference to a rule object that is gone remains
in the set binding list.
Fixes: 26b5a5712eb8 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/netfilter/nf_tables_api.c | 2 ++
1 file changed, 2 insertions(+)
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -3987,6 +3987,8 @@ void nf_tables_deactivate_set(const stru
nft_set_trans_unbind(ctx, set);
if (nft_set_is_anonymous(set))
nft_deactivate_next(ctx->net, set);
+ else
+ list_del_rcu(&binding->list);
set->use--;
break;
next prev parent reply other threads:[~2023-07-25 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230725104521.167250627@linuxfoundation.org>
2023-07-25 10:45 ` [PATCH 5.4 179/313] netfilter: nf_tables: fix nat hook table deletion Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 180/313] netfilter: nftables: add helper function to set the base sequence number Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 181/313] netfilter: add helper function to set up the nfnetlink header and use it Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 182/313] netfilter: nf_tables: use net_generic infra for transaction data Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 183/313] netfilter: nf_tables: add rescheduling points during loop detection walks Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 184/313] netfilter: nf_tables: incorrect error path handling with NFT_MSG_NEWRULE Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 185/313] netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain Greg Kroah-Hartman
2023-07-25 10:45 ` [PATCH 5.4 186/313] netfilter: nf_tables: reject unbound anonymous set before commit phase Greg Kroah-Hartman
2023-07-25 10:45 ` Greg Kroah-Hartman [this message]
2023-07-25 10:45 ` [PATCH 5.4 188/313] netfilter: nf_tables: fix scheduling-while-atomic splat Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725104529.052399107@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).