From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA99AC71156 for ; Fri, 18 Aug 2023 14:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353001AbjHROyJ (ORCPT ); Fri, 18 Aug 2023 10:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377912AbjHROxv (ORCPT ); Fri, 18 Aug 2023 10:53:51 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 532F33C21 for ; Fri, 18 Aug 2023 07:53:50 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qX0rD-0002Cx-DN; Fri, 18 Aug 2023 16:53:47 +0200 Date: Fri, 18 Aug 2023 16:53:47 +0200 From: Florian Westphal To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH] json: use strtok_r() instead of strtok() Message-ID: <20230818145347.GA6510@breakpoint.cc> References: <20230818143348.874561-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818143348.874561-1-thaller@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Thomas Haller wrote: > strtok_r() is probably(?) everywhere available where we care. > Use it. It is thread-safe, and libnftables shouldn't make > assumptions about what other threads of the process are doing. Agree. Applied, thanks.