Re: [PATCH nft] INSTALL: provide examples to install python bindings

[Jeremy Sowden <jeremy@azazel.net>]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On 2023-08-21, at 00:07:20 +0200, Pablo Neira Ayuso wrote:
> Provide examples to install python bindings with legacy setup.py and pip
> with .toml file.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> Florian noticed that `make install` does install python bindings anymore
> when running tests/py. Provide a bit more information on how to manually
> install python bindings in the INSTALL file.
> 
>  INSTALL | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 53021e5aafc3..6b026e2c20c1 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -86,8 +86,13 @@ Installation instructions for nftables
>  
>   CPython bindings are available for nftables under the py/ folder.
>  
> - A pyproject.toml config file and legacy setup.py script are provided to install
> - it.
> + A legacy setup.py script are provided to install:
> +
> +	python setup.py install
> +
> + Alternatively, a pyproject.toml config file is also provided install:
> +
> +	python -m pip install .

How about just:

  CPython bindings are available for nftables under the py/ folder.  They can be
  installed using pip:
   
    python -m pip install py/


J.

>   Source code
>   ===========
> -- 
> 2.30.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]