From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH RFC] tests: add feature probing
Date: Fri, 1 Sep 2023 13:58:19 +0200 [thread overview]
Message-ID: <20230901115819.GJ15759@breakpoint.cc> (raw)
In-Reply-To: <20230831135112.30306-1-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> +check_features()
> +{
> + for ffilename in features/*.nft; do
> + feature=${ffilename#*/}
> + feature=${feature%*.nft}
> + eval NFT_HAVE_${feature}=0
> + $NFT -f "$ffilename" 2>/dev/null
This is broken if run-tests.sh is not invoked inside
tests/shell, I've fixed this up.
Meanwhile I added probe for netdev-chains-without-device and SKIPPED
support:
I: [OK] ././testcases/chains/0044chain_destroy_0
I: [SKIPPED] ././testcases/chains/netdev_chain_0
I: [OK] ././testcases/comments/comments_0
My plan is to keep adding more probe files locally until ./run-tests.sh
passes on 5.14-patched-kernel and then send the batch.
I've also changed the probe files to contain the upstream patch
and its upstream kernel version as a comment.
next prev parent reply other threads:[~2023-09-01 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 13:51 [PATCH RFC] tests: add feature probing Florian Westphal
2023-09-01 11:58 ` Florian Westphal [this message]
2023-09-01 15:37 ` Thomas Haller
2023-09-04 8:53 ` Florian Westphal
2023-09-06 5:44 ` Thomas Haller
2023-09-06 10:04 ` Florian Westphal
2023-09-06 11:03 ` Pablo Neira Ayuso
2023-09-06 11:33 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901115819.GJ15759@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).