From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E393EEE57F2 for ; Fri, 8 Sep 2023 10:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243037AbjIHKYB (ORCPT ); Fri, 8 Sep 2023 06:24:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243030AbjIHKYA (ORCPT ); Fri, 8 Sep 2023 06:24:00 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6E712100 for ; Fri, 8 Sep 2023 03:23:30 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qeYd8-0005bY-3D; Fri, 08 Sep 2023 12:22:26 +0200 Date: Fri, 8 Sep 2023 12:22:26 +0200 From: Florian Westphal To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft 2/2] tests/shell: add missing ".nodump" file for tests without dumps Message-ID: <20230908102226.GA6592@breakpoint.cc> References: <20230907210558.2410789-1-thaller@redhat.com> <20230907210558.2410789-2-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230907210558.2410789-2-thaller@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Thomas Haller wrote: > These files are generated by running `./tests/shell/run-tests.sh -g`. > Commit the .nodump files to git. > > The point is that we can in the future run `./tests/shell/run-tests.sh > -g` and don't get an abundance of irrelevant dump files generated. > > This raises the question, whether some of these tests should actually > have their ruleset compared against a .nft file. But this is nothing > new and not prevented by this change. The change merely expresses in > clear way that those tests are (currently) meant not to have .nft files. I think it would be preferrable to have a patch 2/3 that first adds new .nft dump files for all tests where the output is stable, and then only add the .nodump files (this patch) for those where dump validation cannot work. I suspect that most will pass as expected. Even an empty dump file can be useful because this would catch (unlikely) bugs with delete/flush failure. We could simplify some scripts later on, some of the no-dump scripts manually validate output, that isn't needed anymore after this.