netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Cc: Thomas Haller <thaller@redhat.com>
Subject: [PATCH nft 2/6] tests/shell: drop unstable dump for "transactions/0051map_0" test
Date: Wed, 13 Sep 2023 19:05:05 +0200	[thread overview]
Message-ID: <20230913170649.439394-3-thaller@redhat.com> (raw)
In-Reply-To: <20230913170649.439394-1-thaller@redhat.com>

The file "tests/shell/testcases/transactions/dumps/0051map_0.nft" gets
generated differently on Fedora 38 (6.4.14-200.fc38.x86_64) and
CentOS-Stream-9 (5.14.0-354.el9.x86_64). It's not stable.

    diff --git c/tests/shell/testcases/transactions/dumps/0051map_0.nft w/tests/shell/testcases/transactions/dumps/0051map_0.nft
    index 59d69df70e61..fa7df9f93757 100644
    --- c/tests/shell/testcases/transactions/dumps/0051map_0.nft
    +++ w/tests/shell/testcases/transactions/dumps/0051map_0.nft
    @@ -1,7 +1,11 @@
     table ip x {
    +    chain w {
    +    }
    +
         chain m {
         }

         chain y {
    +         ip saddr vmap { 1.1.1.1 : jump w, 2.2.2.2 : accept, 3.3.3.3 : goto m }
         }
     }

Drop it.

Signed-off-by: Thomas Haller <thaller@redhat.com>
---
 tests/shell/testcases/transactions/dumps/0051map_0.nft    | 7 -------
 tests/shell/testcases/transactions/dumps/0051map_0.nodump | 0
 2 files changed, 7 deletions(-)
 delete mode 100644 tests/shell/testcases/transactions/dumps/0051map_0.nft
 create mode 100644 tests/shell/testcases/transactions/dumps/0051map_0.nodump

diff --git a/tests/shell/testcases/transactions/dumps/0051map_0.nft b/tests/shell/testcases/transactions/dumps/0051map_0.nft
deleted file mode 100644
index 59d69df70e61..000000000000
--- a/tests/shell/testcases/transactions/dumps/0051map_0.nft
+++ /dev/null
@@ -1,7 +0,0 @@
-table ip x {
-	chain m {
-	}
-
-	chain y {
-	}
-}
diff --git a/tests/shell/testcases/transactions/dumps/0051map_0.nodump b/tests/shell/testcases/transactions/dumps/0051map_0.nodump
new file mode 100644
index 000000000000..e69de29bb2d1
-- 
2.41.0


  parent reply	other threads:[~2023-09-13 17:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 17:05 [PATCH nft 0/6] adjust nft dump files and add check-tree script Thomas Haller
2023-09-13 17:05 ` [PATCH nft 1/6] tests/shell: remove spurious .nft dump files Thomas Haller
2023-09-13 17:05 ` Thomas Haller [this message]
2023-09-13 17:05 ` [PATCH nft 3/6] tests/shell: add missing nft/nodump files for tests Thomas Haller
2023-09-13 17:05 ` [PATCH nft 4/6] tests/shell: special handle base path starting with "./" Thomas Haller
2023-09-13 17:05 ` [PATCH nft 5/6] tests/shell: in find_tests() use C locale for sorting tests names Thomas Haller
2023-09-13 17:05 ` [PATCH nft 6/6] tools: add "tools/check-tree.sh" script to check consistency of nft dumps Thomas Haller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913170649.439394-3-thaller@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).