From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFC9CD5BC2 for ; Tue, 19 Sep 2023 13:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232469AbjISN7q (ORCPT ); Tue, 19 Sep 2023 09:59:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232437AbjISN7q (ORCPT ); Tue, 19 Sep 2023 09:59:46 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53832EC for ; Tue, 19 Sep 2023 06:59:40 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qibGM-0007V4-Oj; Tue, 19 Sep 2023 15:59:38 +0200 Date: Tue, 19 Sep 2023 15:59:38 +0200 From: Florian Westphal To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [PATCH nf] netfilter: nf_tables: fix memory leak when more than 255 elements expired Message-ID: <20230919135938.GC23945@breakpoint.cc> References: <20230919133616.20436-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230919133616.20436-1-fw@strlen.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Florian Westphal wrote: > When more than 255 elements expire we're supposed to switch to a new gc > container structure, but nft_trans_gc_space() always returns false in this Grrr. This should read 'always returns true' or 'never returns false', but not *THIS*. I'll fix this up when applying this, probably tomorrow morning.