* [PATCH 4.19 046/273] netfilter: nft_flow_offload: fix underflow in flowtable reference counter [not found] <20230920112846.440597133@linuxfoundation.org> @ 2023-09-20 11:28 ` Greg Kroah-Hartman 2023-09-20 11:28 ` [PATCH 4.19 047/273] netfilter: nf_tables: missing NFT_TRANS_PREPARE_ERROR in flowtable deactivatation Greg Kroah-Hartman 1 sibling, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2023-09-20 11:28 UTC (permalink / raw) To: stable, netfilter-devel Cc: Greg Kroah-Hartman, patches, wenxu, Pablo Neira Ayuso 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: wenxu <wenxu@ucloud.cn> commit 8ca79606cdfde2e37ee4f0707b9d1874a6f0eb38 upstream. The .deactivate and .activate interfaces already deal with the reference counter. Otherwise, this results in spurious "Device is busy" errors. Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression") Signed-off-by: wenxu <wenxu@ucloud.cn> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/netfilter/nft_flow_offload.c | 3 --- 1 file changed, 3 deletions(-) --- a/net/netfilter/nft_flow_offload.c +++ b/net/netfilter/nft_flow_offload.c @@ -197,9 +197,6 @@ static void nft_flow_offload_activate(co static void nft_flow_offload_destroy(const struct nft_ctx *ctx, const struct nft_expr *expr) { - struct nft_flow_offload *priv = nft_expr_priv(expr); - - priv->flowtable->use--; nf_ct_netns_put(ctx->net, ctx->family); } ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 4.19 047/273] netfilter: nf_tables: missing NFT_TRANS_PREPARE_ERROR in flowtable deactivatation [not found] <20230920112846.440597133@linuxfoundation.org> 2023-09-20 11:28 ` [PATCH 4.19 046/273] netfilter: nft_flow_offload: fix underflow in flowtable reference counter Greg Kroah-Hartman @ 2023-09-20 11:28 ` Greg Kroah-Hartman 1 sibling, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2023-09-20 11:28 UTC (permalink / raw) To: stable, netfilter-devel; +Cc: Greg Kroah-Hartman, patches, Pablo Neira Ayuso 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pablo Neira Ayuso <pablo@netfilter.org> commit 26b5a5712eb85e253724e56a54c17f8519bd8e4e upstream. Missing NFT_TRANS_PREPARE_ERROR in 1df28fde1270 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain") in 4.19. Fixes: 1df28fde1270 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain") in 4.19 Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- net/netfilter/nf_tables_api.c | 1 + 1 file changed, 1 insertion(+) --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -5555,6 +5555,7 @@ void nf_tables_deactivate_flowtable(cons enum nft_trans_phase phase) { switch (phase) { + case NFT_TRANS_PREPARE_ERROR: case NFT_TRANS_PREPARE: case NFT_TRANS_ABORT: case NFT_TRANS_RELEASE: ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-20 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230920112846.440597133@linuxfoundation.org>
2023-09-20 11:28 ` [PATCH 4.19 046/273] netfilter: nft_flow_offload: fix underflow in flowtable reference counter Greg Kroah-Hartman
2023-09-20 11:28 ` [PATCH 4.19 047/273] netfilter: nf_tables: missing NFT_TRANS_PREPARE_ERROR in flowtable deactivatation Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).