From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39131CE79CF for ; Wed, 20 Sep 2023 12:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235554AbjITMvG (ORCPT ); Wed, 20 Sep 2023 08:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235056AbjITMvG (ORCPT ); Wed, 20 Sep 2023 08:51:06 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5755783; Wed, 20 Sep 2023 05:51:00 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qiwfQ-0006kz-Rn; Wed, 20 Sep 2023 14:50:56 +0200 Date: Wed, 20 Sep 2023 14:50:56 +0200 From: Florian Westphal To: Jan Engelhardt Cc: Jozsef Kadlecsik , netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, sam@gentoo.org Subject: Re: [ANNOUNCE] ipset 7.18 released Message-ID: <20230920125056.GA25778@breakpoint.cc> References: <55c2bf9d-ec58-8db-e457-8a36ebbbc4c0@blackhole.kfki.hu> <382279q3-6on5-32rq-po59-6r18os6934n9@vanv.qr> <0r045rnn-70s8-34pq-o5o3-nr3q48n9sq68@vanv.qr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0r045rnn-70s8-34pq-o5o3-nr3q48n9sq68@vanv.qr> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Jan Engelhardt wrote: You might want to CC author of that change. > On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote: > >On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote: > >> > >>I'm happy to announce ipset 7.18, which brings a few fixes, backports, > >>tests suite fixes and json output support. > > > >The installation of the pkgconfig file is now broken. > > > >> - lib/Makefile.am: fix pkgconfig dir (Sam James) > > > >Aaaaagh.. that change completely broke installation and must be reverted. > > commit 326932be0c4f47756f9809cad5a103ac310f700d > Author: Sam James > Date: Sat Jan 28 19:23:54 2023 +0100 > > lib/Makefile.am: fix pkgconfig dir > > Signed-off-by: Sam James > Signed-off-by: Jozsef Kadlecsik > > Can I just take a moment to vent about this some more. > The change is, in the words of another Linux developer, utter garbage. > ${libdir} contains ${prefix} and did so for eternities. > > The commit message is utter garbage too, because it does not > even try to make an argument to even _have_ the change in the > first place. Allowing such an underdocumented change is a > failure in the review process itself.