* [nft PATCH] tests: shell: features: Fix table owner flag check
@ 2023-09-26 19:56 Phil Sutter
2023-09-26 19:58 ` Phil Sutter
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2023-09-26 19:56 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Florian Westphal, netfilter-devel
The keyword is "flags", not "flag". Resulted in a false-negative:
features/table_flag_owner.nft:4:2-5: Error: syntax error, unexpected string
flag owner;
^^^^
Fixes: 10373f0936cd3 ("tests: shell: skip flowtable-uaf if we lack table owner support")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
tests/shell/features/table_flag_owner.nft | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shell/features/table_flag_owner.nft b/tests/shell/features/table_flag_owner.nft
index 6e6f608a7e940..aef122a0724bf 100644
--- a/tests/shell/features/table_flag_owner.nft
+++ b/tests/shell/features/table_flag_owner.nft
@@ -1,5 +1,5 @@
# 6001a930ce03 ("netfilter: nftables: introduce table ownership")
# v5.12-rc1~200^2~6^2
table t {
- flag owner;
+ flags owner;
}
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nft PATCH] tests: shell: features: Fix table owner flag check
2023-09-26 19:56 [nft PATCH] tests: shell: features: Fix table owner flag check Phil Sutter
@ 2023-09-26 19:58 ` Phil Sutter
0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2023-09-26 19:58 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Florian Westphal, netfilter-devel
On Tue, Sep 26, 2023 at 09:56:22PM +0200, Phil Sutter wrote:
> The keyword is "flags", not "flag". Resulted in a false-negative:
>
> features/table_flag_owner.nft:4:2-5: Error: syntax error, unexpected string
> flag owner;
> ^^^^
>
> Fixes: 10373f0936cd3 ("tests: shell: skip flowtable-uaf if we lack table owner support")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-26 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 19:56 [nft PATCH] tests: shell: features: Fix table owner flag check Phil Sutter
2023-09-26 19:58 ` Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).