From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA214E8FDD1 for ; Wed, 4 Oct 2023 08:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232743AbjJDIHI (ORCPT ); Wed, 4 Oct 2023 04:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbjJDIHH (ORCPT ); Wed, 4 Oct 2023 04:07:07 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C210B83 for ; Wed, 4 Oct 2023 01:07:04 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qnwuM-0008Ow-TE; Wed, 04 Oct 2023 10:07:02 +0200 Date: Wed, 4 Oct 2023 10:07:02 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: Phil Sutter , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf] netfilter: nf_tables: do not refresh timeout when resetting element Message-ID: <20231004080702.GD15013@breakpoint.cc> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > We will soon need NFT_MSG_GETRULE_RESET_NO_TIMEOUT to undo this combo > command semantics, from userspace this will require some sort of 'nft > reset table x notimeout' syntax. NFT_MSG_GETRULE_RESET_NO_TIMEOUT sounds super ugly :/ Do you think we can add a flags attr that describes which parts to reset? No flags attr would reset everything. Do you consider reset of timers to be something that must be handled via transaction infra or do you think it can (re)use the dump-and-reset approach?