From: Florian Westphal <fw@strlen.de>
To: George Guo <dongtai.guo@linux.dev>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, George Guo <guodongtai@kylinos.cn>
Subject: Re: [PATCH] netfilter: remove inaccurate code comments from struct nft_table
Date: Sat, 7 Oct 2023 12:53:35 +0200 [thread overview]
Message-ID: <20231007105335.GB20662@breakpoint.cc> (raw)
In-Reply-To: <20231007102528.1544295-1-dongtai.guo@linux.dev>
George Guo <dongtai.guo@linux.dev> wrote:
> From: George Guo <guodongtai@kylinos.cn>
>
> afinfo is no longer a member of struct nft_table, so remove the comment
> for it.
Correct, but could you please send a v2 that fixes up
all the comments and gets them back in sync with the structure?
Eg. nlpid, family, udlen and udata exist in struct
but are not mentioned in the comments.
next prev parent reply other threads:[~2023-10-07 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 10:25 [PATCH] netfilter: remove inaccurate code comments from struct nft_table George Guo
2023-10-07 10:53 ` Florian Westphal [this message]
2023-10-09 2:55 ` [PATCH v2] netfilter: cleanup " George Guo
2023-10-13 9:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231007105335.GB20662@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dongtai.guo@linux.dev \
--cc=edumazet@google.com \
--cc=guodongtai@kylinos.cn \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).