From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B224E95A67 for ; Sun, 8 Oct 2023 12:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344749AbjJHM3k (ORCPT ); Sun, 8 Oct 2023 08:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjJHM3j (ORCPT ); Sun, 8 Oct 2023 08:29:39 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA834B9; Sun, 8 Oct 2023 05:29:38 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qpSud-0002oP-Lz; Sun, 08 Oct 2023 14:29:35 +0200 Date: Sun, 8 Oct 2023 14:29:35 +0200 From: Florian Westphal To: chenguohua@jari.cn Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h Message-ID: <20231008122935.GB29696@breakpoint.cc> References: <33d535ba.863.18ad54575ed.Coremail.chenguohua@jari.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33d535ba.863.18ad54575ed.Coremail.chenguohua@jari.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org chenguohua@jari.cn wrote: > Fix the following errors reported by checkpatch: > > ERROR: "foo * bar" should be "foo *bar" Running "checkpatch -f" for all nf related files results in a myriad of "warnings". I don't think there is a good reason to "fix" them. checkpatch is good for new patch submissions, but I do not think its worth it to adjust all the existing files. Sorry.