From: Simon Horman <horms@kernel.org>
To: George Guo <guodongtai@kylinos.cn>
Cc: fw@strlen.de, coreteam@netfilter.org, davem@davemloft.net,
dongtai.guo@linux.dev, edumazet@google.com, kadlec@netfilter.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pabeni@redhat.com, pablo@netfilter.org
Subject: Re: [PATCH v2] netfilter: cleanup struct nft_table
Date: Fri, 13 Oct 2023 11:26:12 +0200 [thread overview]
Message-ID: <20231013092612.GA29570@kernel.org> (raw)
In-Reply-To: <20231009025548.3522409-1-guodongtai@kylinos.cn>
On Mon, Oct 09, 2023 at 10:55:48AM +0800, George Guo wrote:
> Add comments for nlpid, family, udlen and udata in struct nft_table, and
> afinfo is no longer a member of struct nft_table, so remove the comment
> for it.
>
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
Thanks,
I checked that the fields of the structure now match the kernel doc
for struct nft_table.
I might have mentioned kernel doc, or similar in the subject,
but I don't think there is a need to respin because of that.
As a follow-up, you may want to consider addressing
other kernel doc problems in the same file.
The following command may be helpful there.
./scripts/kernel-doc -none include/net/netfilter/nf_tables.h
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2023-10-13 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 10:25 [PATCH] netfilter: remove inaccurate code comments from struct nft_table George Guo
2023-10-07 10:53 ` Florian Westphal
2023-10-09 2:55 ` [PATCH v2] netfilter: cleanup " George Guo
2023-10-13 9:26 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013092612.GA29570@kernel.org \
--to=horms@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dongtai.guo@linux.dev \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=guodongtai@kylinos.cn \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).