From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Cc: Thomas Haller <thaller@redhat.com>
Subject: [PATCH nft v2 1/5] build: add basic "check-{local,more,all}" and "build-all" make targets
Date: Sun, 5 Nov 2023 16:08:37 +0100 [thread overview]
Message-ID: <20231105150955.349966-2-thaller@redhat.com> (raw)
In-Reply-To: <20231105150955.349966-1-thaller@redhat.com>
Add targets "check-local" and "check-more", which later will hook
up additional tests. For now, they are empty targets.
- with autotools, `make distcheck` implies `make check`.
- with autotools, `make check` implies `make check-local` and `make
check-TESTS`.
Most tests should of course hook via `check-local` or via `TESTS=`
(`check-TESTS`). There is a small place for additional tests, in
particular "tests/build/run-tests.sh", which itself runs `make
distcheck`. So `make check-more` contains additional tests not run by
`make check`.
And `make check-all` just means `make check check-more`.
Signed-off-by: Thomas Haller <thaller@redhat.com>
---
Makefile.am | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 0ed831a19e95..93bd47970077 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -31,8 +31,11 @@ lib_LTLIBRARIES =
noinst_LTLIBRARIES =
sbin_PROGRAMS =
check_PROGRAMS =
+check_LTLIBRARIES =
dist_man_MANS =
CLEANFILES =
+check_local =
+check_more =
###############################################################################
@@ -409,3 +412,23 @@ EXTRA_DIST += \
pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = libnftables.pc
+
+###############################################################################
+
+build-all: all $(check_PROGRAMS) $(check_LTLIBRARIES)
+
+.PHONY: build-all
+
+###############################################################################
+
+check-local: build-all $(check_local)
+
+.PHONY: check-local $(check_local)
+
+check-more: build-all $(check_more)
+
+.PHONY: check-more $(check_more)
+
+check-all: check check-more
+
+.PHONY: check-all
--
2.41.0
next prev parent reply other threads:[~2023-11-05 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 15:08 [PATCH nft v2 0/5] add infrastructure for unit tests Thomas Haller
2023-11-05 15:08 ` Thomas Haller [this message]
2023-11-05 15:08 ` [PATCH nft v2 2/5] build: add `make check-build` to run `./tests/build/run-tests.sh` Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 3/5] build: add `make check-tree` to check consistency of source tree Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 4/5] build: cleanup if-blocks for conditional compilation in "Makefile.am" Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 5/5] tests/unit: add unit tests for libnftables Thomas Haller
2023-11-21 12:34 ` [PATCH nft v2 0/5] add infrastructure for unit tests Thomas Haller
2023-11-21 12:37 ` Pablo Neira Ayuso
2023-12-06 7:53 ` Thomas Haller
2023-12-06 17:18 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231105150955.349966-2-thaller@redhat.com \
--to=thaller@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).