netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Cc: Thomas Haller <thaller@redhat.com>
Subject: [PATCH nft v2 2/5] build: add `make check-build` to run `./tests/build/run-tests.sh`
Date: Sun,  5 Nov 2023 16:08:38 +0100	[thread overview]
Message-ID: <20231105150955.349966-3-thaller@redhat.com> (raw)
In-Reply-To: <20231105150955.349966-1-thaller@redhat.com>

`./tests/build/run-tests.sh` performs a build check. Integrate it in
make as `make check-build` target.

`make check-build` is hooked into `make check-more`, which in turn is
hooked as `make check-all`.

Note that this is intentionally not part of `make check`, because `make
check` is run by `make distcheck`, and the build test itself calls `make
distcheck`. Even if that cycle would be resolved, doing a build check
several times during `make check` seems wrong and would add another
minute to the test runtime.

Signed-off-by: Thomas Haller <thaller@redhat.com>
---
 Makefile.am | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index 93bd47970077..6a0b04641afc 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -421,6 +421,14 @@ build-all: all $(check_PROGRAMS) $(check_LTLIBRARIES)
 
 ###############################################################################
 
+check-build: build-all
+	cd "$(srcdir)/tests/build/" ; \
+	CC="$(CC)" CFLAGS='-Werror' ./run-tests.sh
+
+check_more += check-build
+
+###############################################################################
+
 check-local: build-all $(check_local)
 
 .PHONY: check-local $(check_local)
-- 
2.41.0


  parent reply	other threads:[~2023-11-05 15:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-05 15:08 [PATCH nft v2 0/5] add infrastructure for unit tests Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 1/5] build: add basic "check-{local,more,all}" and "build-all" make targets Thomas Haller
2023-11-05 15:08 ` Thomas Haller [this message]
2023-11-05 15:08 ` [PATCH nft v2 3/5] build: add `make check-tree` to check consistency of source tree Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 4/5] build: cleanup if-blocks for conditional compilation in "Makefile.am" Thomas Haller
2023-11-05 15:08 ` [PATCH nft v2 5/5] tests/unit: add unit tests for libnftables Thomas Haller
2023-11-21 12:34 ` [PATCH nft v2 0/5] add infrastructure for unit tests Thomas Haller
2023-11-21 12:37   ` Pablo Neira Ayuso
2023-12-06  7:53     ` Thomas Haller
2023-12-06 17:18       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231105150955.349966-3-thaller@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).