From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 1/3] arptables: Fix formatting of numeric --h-type output
Date: Wed, 8 Nov 2023 10:13:12 +0100 [thread overview]
Message-ID: <20231108091312.GB5721@breakpoint.cc> (raw)
In-Reply-To: <20231108033130.18747-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Arptables expects numeric arguments to --h-type option in hexadecimal
> form, even if no '0x'-prefix is present. In contrast, it prints such
> values in decimal. This is not just inconsistent, but makes it
> impossible to save and later restore a ruleset without fixing up the
> values in between.
>
> Assuming that the parser side can't be changed for compatibility
> reasons, fix the output side instead.
>
> This is a day 1 bug and present in legacy arptables as well, so treat
> this as a "feature" of arptables-nft and omit a Fixes: tag.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2023-11-08 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 3:31 [iptables PATCH 1/3] arptables: Fix formatting of numeric --h-type output Phil Sutter
2023-11-08 3:31 ` [iptables PATCH 2/3] arptables: Fix --proto-type mask formatting Phil Sutter
2023-11-08 3:31 ` [iptables PATCH 3/3] extensions: libarpt_standard.t: Add a rule with builtin option masks Phil Sutter
2023-11-08 9:13 ` Florian Westphal [this message]
2023-11-09 14:56 ` [iptables PATCH 1/3] arptables: Fix formatting of numeric --h-type output Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108091312.GB5721@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).