From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 620F4C4332F for ; Thu, 9 Nov 2023 23:21:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjKIXVs (ORCPT ); Thu, 9 Nov 2023 18:21:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjKIXVr (ORCPT ); Thu, 9 Nov 2023 18:21:47 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85348420F for ; Thu, 9 Nov 2023 15:21:45 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1r1ELH-0006I7-QO; Fri, 10 Nov 2023 00:21:43 +0100 Date: Fri, 10 Nov 2023 00:21:43 +0100 From: Florian Westphal To: Thomas Haller Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nft 01/12] tests: shell: export DIFF to use it from feature scripts Message-ID: <20231109232143.GC8000@breakpoint.cc> References: <20231109162304.119506-1-pablo@netfilter.org> <20231109162304.119506-2-pablo@netfilter.org> <3b81fb7a25e8daf8a6c2c76ab0672207cf2c09c0.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b81fb7a25e8daf8a6c2c76ab0672207cf2c09c0.camel@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Thomas Haller wrote: > I think one day, > > sed 's/\$DIFF\>/diff/g' -i $(git grep -l DIFF tests/shell/) > > should be done. FWIW I agree with this.