From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69929C07548 for ; Wed, 15 Nov 2023 08:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234676AbjKOIYc (ORCPT ); Wed, 15 Nov 2023 03:24:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbjKOIYc (ORCPT ); Wed, 15 Nov 2023 03:24:32 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2DC6EE for ; Wed, 15 Nov 2023 00:24:28 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1r3BCF-0005i4-4I; Wed, 15 Nov 2023 09:24:27 +0100 Date: Wed, 15 Nov 2023 09:24:27 +0100 From: Florian Westphal To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files Message-ID: <20231115082427.GC14621@breakpoint.cc> References: <20231114153150.406334-1-thaller@redhat.com> <20231114160903.409552-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231114160903.409552-1-thaller@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Thomas Haller wrote: > The rules after a successful test are good opportunity to test > `nft -j list ruleset` and `nft -j --check`. This quite possibly touches > code paths that are not hit by other tests yet. This series looks good to me, I'll apply it in the next few hours if noone else takes any action by then.