From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806D6C47072 for ; Wed, 15 Nov 2023 10:10:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234651AbjKOKK0 (ORCPT ); Wed, 15 Nov 2023 05:10:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234680AbjKOKK0 (ORCPT ); Wed, 15 Nov 2023 05:10:26 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 533C210F for ; Wed, 15 Nov 2023 02:10:22 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1r3Cqi-0006Mw-IO; Wed, 15 Nov 2023 11:10:20 +0100 Date: Wed, 15 Nov 2023 11:10:20 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , Thomas Haller , NetFilter Subject: Re: [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files Message-ID: <20231115101020.GB23742@breakpoint.cc> References: <20231114153150.406334-1-thaller@redhat.com> <20231114160903.409552-1-thaller@redhat.com> <20231115082427.GC14621@breakpoint.cc> <20231115100101.GA23742@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > because I am currently figuring out how to detach pipapo support from > it without losing coverage. Is it worth the pain? I'd probably lean towards skipping the test entirely, splitting it in two is possible but we'd end up with quite some duplicated scripting.