netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Cc: Thomas Haller <thaller@redhat.com>
Subject: [PATCH nft 0/2] pretty print .json-nft files
Date: Fri, 24 Nov 2023 13:45:52 +0100	[thread overview]
Message-ID: <20231124124759.3269219-1-thaller@redhat.com> (raw)

The plain `nft -j list ruleset` output is hard to read in diffs.
Instead, commit pretty printed JSON to git and compare that.

Existing .json-nft continue to work, and don't need to be regenerated.
But when the dump content changes, the prettified version is committed
to git.

Thomas Haller (2):
  tests/shell: use generated ruleset for `nft --check`
  tests/shell: have .json-nft dumps prettified to wrap lines

 tests/shell/helpers/json-pretty.sh  | 27 +++++++---
 tests/shell/helpers/test-wrapper.sh | 81 ++++++++++++++++++++---------
 2 files changed, 75 insertions(+), 33 deletions(-)

-- 
2.42.0


             reply	other threads:[~2023-11-24 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24 12:45 Thomas Haller [this message]
2023-11-24 12:45 ` [PATCH nft 1/2] tests/shell: use generated ruleset for `nft --check` Thomas Haller
2023-11-24 12:45 ` [PATCH nft 2/2] tests/shell: have .json-nft dumps prettified to wrap lines Thomas Haller
2023-12-07  9:08   ` [PATCH nft 2/2 v2] " Thomas Haller
2024-02-08 17:31     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231124124759.3269219-1-thaller@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).