From: Florian Westphal <fw@strlen.de>
To: Eric Garver <eric@garver.life>, Phil Sutter <phil@nwl.cc>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [nf-next PATCH] netfilter: nf_tables: Support updating table's owner flag
Date: Wed, 13 Dec 2023 16:29:04 +0100 [thread overview]
Message-ID: <20231213152904.GD27081@breakpoint.cc> (raw)
In-Reply-To: <ZXm6zI16aVSwvEDB@egarver-mac>
Eric Garver <eric@garver.life> wrote:
> On Wed, Dec 13, 2023 at 01:13:54PM +0100, Phil Sutter wrote:
> > Hi,
> >
> > On Tue, Dec 12, 2023 at 05:47:22PM -0500, Eric Garver wrote:
> > > I'm not concerned with optimizing for the crash case. We wouldn't be
> > > able to make any assumptions about the state of nftables. The only safe
> > > option is to flush and reload all the rules.
> >
> > The problem with crashes is tables with owner flag set will vanish,
> > leaving the system without a firewall.
>
> I'd rather see the daemon be automatically restarted. After a crash you
> still have a flush + re-apply on daemon restart. Avoiding the cleanup
> due to table owner flag only shortens the window.
But the filter rules are gone for a short time, leaving e.g. an
ipv6 network we're routing for wide open.
Same for any exposed containers or VMs.
So I'd say as-is the owner flag is harmful for filtering.
I'm fine with adding a flag that keeps the orphaned table around
and allows to (re)take ownership.
next prev parent reply other threads:[~2023-12-13 15:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 13:01 [nf-next PATCH] netfilter: nf_tables: Support updating table's owner flag Phil Sutter
2023-12-12 13:08 ` Pablo Neira Ayuso
2023-12-12 16:23 ` Phil Sutter
2023-12-12 22:47 ` Eric Garver
2023-12-13 12:13 ` Phil Sutter
2023-12-13 14:08 ` Eric Garver
2023-12-13 15:29 ` Florian Westphal [this message]
2023-12-13 15:15 ` Pablo Neira Ayuso
2023-12-13 15:51 ` Phil Sutter
2023-12-13 15:54 ` Pablo Neira Ayuso
2023-12-13 16:32 ` Thomas Haller
2023-12-13 16:45 ` Florian Westphal
2023-12-13 17:04 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213152904.GD27081@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox