netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Cc: Florian Westphal <fw@strlen.de>
Subject: [iptables PATCH v2 0/3] iptables-save: Avoid /etc/protocols lookups
Date: Wed, 10 Jan 2024 23:41:33 +0100	[thread overview]
Message-ID: <20240110224136.11211-1-phil@nwl.cc> (raw)

V1 was a tad too simple: The revert is fine, but the (now) third patch
changes iptables-save output and thus potentially breaks test cases. To
avoid that, add patch 2 which enables "dccp" and "ipcomp" protocol names
in output. Apart from that, a single shell test case expected '-p gre'
in the dump. Replace the actually printed '-p 47' using sed in there.

Phil Sutter (3):
  Revert "xshared: Print protocol numbers if --numeric was given"
  libxtables: Add dccp and ipcomp to xtables_chain_protos
  iptables-save: Avoid /etc/protocols lookups

 .../shell/testcases/ip6tables/0002-verbose-output_0    | 10 +++++-----
 .../testcases/ipt-restore/0011-noflush-empty-line_0    |  2 +-
 .../tests/shell/testcases/ipt-save/0001load-dumps_0    |  1 +
 .../shell/testcases/iptables/0002-verbose-output_0     |  4 ++--
 iptables/xshared.c                                     |  8 ++++----
 libxtables/xtables.c                                   |  2 ++
 6 files changed, 15 insertions(+), 12 deletions(-)

-- 
2.43.0

             reply	other threads:[~2024-01-10 22:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 22:41 Phil Sutter [this message]
2024-01-10 22:41 ` [iptables PATCH v2 1/3] Revert "xshared: Print protocol numbers if --numeric was given" Phil Sutter
2024-01-10 22:41 ` [iptables PATCH v2 2/3] libxtables: Add dccp and ipcomp to xtables_chain_protos Phil Sutter
2024-01-10 22:41 ` [iptables PATCH v2 3/3] iptables-save: Avoid /etc/protocols lookups Phil Sutter
2024-02-06 23:25 ` [iptables PATCH v2 0/3] " Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110224136.11211-1-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).