From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Ale Crismani <ale.crismani@automattic.com>,
David Wang <00107082@163.com>, Eric Dumazet <edumazet@google.com>
Subject: [PATCH 0/1] ipset performance regression in swap fix
Date: Mon, 29 Jan 2024 10:57:00 +0100 [thread overview]
Message-ID: <20240129095701.388482-1-kadlec@netfilter.org> (raw)
Hi Pablo,
Please consider to apply the next patch to your nf tree. It should be applied
to all stable branches to which the patch "netfilter: ipset: fix race condition
between swap/destroy and kernel side add/del/test", commit 28628fa9 was added.
* The synchronize_rcu() call added to the swap function to prevent the race
condition makes it too slow. The race can be prevented by using call_rcu()
in the destroy function instead. However those function calls cannot wait,
so cancelling garbage collectors are separated to individual function calls
to execute them first, outside of the call_rcu() functions.
Best regards,
Jozsef
The following changes since commit ac631873c9e7a50d2a8de457cfc4b9f86666403e:
net: ethernet: cortina: Drop TSO support (2024-01-07 16:05:00 +0000)
are available in the Git repository at:
git://blackhole.kfki.hu/nf fdb8e12cc2ccb5e06a
for you to fetch changes up to fdb8e12cc2ccb5e06af6bcd68ba578b60807bcf6:
netfilter: ipset: fix performance regression in swap operation (2024-01-29 10:47:14 +0100)
----------------------------------------------------------------
Jozsef Kadlecsik (1):
netfilter: ipset: fix performance regression in swap operation
include/linux/netfilter/ipset/ip_set.h | 4 ++++
net/netfilter/ipset/ip_set_bitmap_gen.h | 14 ++++++++++---
net/netfilter/ipset/ip_set_core.c | 37 +++++++++++++++++++++++++--------
net/netfilter/ipset/ip_set_hash_gen.h | 15 ++++++++++---
net/netfilter/ipset/ip_set_list_set.c | 13 +++++++++---
5 files changed, 65 insertions(+), 18 deletions(-)
next reply other threads:[~2024-01-29 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 9:57 Jozsef Kadlecsik [this message]
2024-01-29 9:57 ` [PATCH 1/1] netfilter: ipset: fix performance regression in swap operation Jozsef Kadlecsik
-- strict thread matches above, loose matches on Subject: below --
2024-01-16 16:29 [PATCH 0/1] ipset performance regression in swap fix Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129095701.388482-1-kadlec@netfilter.org \
--to=kadlec@netfilter.org \
--cc=00107082@163.com \
--cc=ale.crismani@automattic.com \
--cc=edumazet@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).