* [PATCH] netfilter: xtables: fix IP6_NF_IPTABLES_LEGACY typo
@ 2024-02-24 12:13 Arnd Bergmann
2024-02-24 13:23 ` Florian Westphal
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-02-24 12:13 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal
Cc: Arnd Bergmann, David S. Miller, David Ahern, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netfilter-devel, coreteam, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
CONFIG_IP_NF_NAT accidentally selects the wrong NF_IPTABLES_LEGACY
symbol, which ends up causing a link failure in some configurations:
WARNING: unmet direct dependencies detected for IP6_NF_IPTABLES_LEGACY
Depends on [n]: NET [=y] && INET [=y] && IPV6 [=n] && NETFILTER [=y]
Selected by [m]:
Select IP_NF_IPTABLES_LEGACY instead of IP6_NF_IPTABLES_LEGACY.
Fixes: a9525c7f6219 ("netfilter: xtables: allow xtables-nft only builds")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/ipv4/netfilter/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index 87d890172809..8f6e950163a7 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -217,7 +217,7 @@ config IP_NF_NAT
default m if NETFILTER_ADVANCED=n
select NF_NAT
select NETFILTER_XT_NAT
- select IP6_NF_IPTABLES_LEGACY
+ select IP_NF_IPTABLES_LEGACY
help
This enables the `nat' table in iptables. This allows masquerading,
port forwarding and other forms of full Network Address Port
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] netfilter: xtables: fix IP6_NF_IPTABLES_LEGACY typo
2024-02-24 12:13 [PATCH] netfilter: xtables: fix IP6_NF_IPTABLES_LEGACY typo Arnd Bergmann
@ 2024-02-24 13:23 ` Florian Westphal
0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2024-02-24 13:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
Arnd Bergmann, David S. Miller, David Ahern, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netfilter-devel, coreteam, netdev,
linux-kernel
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> CONFIG_IP_NF_NAT accidentally selects the wrong NF_IPTABLES_LEGACY
> symbol, which ends up causing a link failure in some configurations:
>
> WARNING: unmet direct dependencies detected for IP6_NF_IPTABLES_LEGACY
> Depends on [n]: NET [=y] && INET [=y] && IPV6 [=n] && NETFILTER [=y]
> Selected by [m]:
>
> Select IP_NF_IPTABLES_LEGACY instead of IP6_NF_IPTABLES_LEGACY.
Patch is correct but this is already fixed via
749d4ef0868c ("netfilter: xtables: fix up kconfig dependencies")
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-24 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-24 12:13 [PATCH] netfilter: xtables: fix IP6_NF_IPTABLES_LEGACY typo Arnd Bergmann
2024-02-24 13:23 ` Florian Westphal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).