netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>
Cc: oe-kbuild-all@lists.linux.dev, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, Pablo Neira Ayuso <pablo@netfilter.org>,
	Stefano Brivio <sbrivio@redhat.com>
Subject: [netfilter-nf:under-review 14/18] net/netfilter/nft_set_pipapo.c:2122: warning: expecting prototype for __nft_pipapo_walk(). Prototype was for nft_pipapo_do_walk() instead
Date: Fri, 3 May 2024 16:03:53 +0800	[thread overview]
Message-ID: <202405031522.nDHvTzEz-lkp@intel.com> (raw)

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git under-review
head:   7ab960ad3bd958ddbeabe9ab2287ac5d0a673f23
commit: cd491237776df450e99904b9408bfad35366a73f [14/18] netfilter: nft_set_pipapo: prepare walk function for on-demand clone
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240503/202405031522.nDHvTzEz-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405031522.nDHvTzEz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405031522.nDHvTzEz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/netfilter/nft_set_pipapo.c:2122: warning: expecting prototype for __nft_pipapo_walk(). Prototype was for nft_pipapo_do_walk() instead


vim +2122 net/netfilter/nft_set_pipapo.c

3c4287f62044a90 Stefano Brivio    2020-01-22  2107  
3c4287f62044a90 Stefano Brivio    2020-01-22  2108  /**
cd491237776df45 Florian Westphal  2024-04-25  2109   * __nft_pipapo_walk() - Walk over elements in m
3c4287f62044a90 Stefano Brivio    2020-01-22  2110   * @ctx:	nftables API context
3c4287f62044a90 Stefano Brivio    2020-01-22  2111   * @set:	nftables API set representation
cd491237776df45 Florian Westphal  2024-04-25  2112   * @m:		matching data pointing to key mapping array
3c4287f62044a90 Stefano Brivio    2020-01-22  2113   * @iter:	Iterator
3c4287f62044a90 Stefano Brivio    2020-01-22  2114   *
3c4287f62044a90 Stefano Brivio    2020-01-22  2115   * As elements are referenced in the mapping array for the last field, directly
3c4287f62044a90 Stefano Brivio    2020-01-22  2116   * scan that array: there's no need to follow rule mappings from the first
cd491237776df45 Florian Westphal  2024-04-25  2117   * field. @m is protected either by RCU read lock or by transaction mutex.
3c4287f62044a90 Stefano Brivio    2020-01-22  2118   */
cd491237776df45 Florian Westphal  2024-04-25  2119  static void nft_pipapo_do_walk(const struct nft_ctx *ctx, struct nft_set *set,
cd491237776df45 Florian Westphal  2024-04-25  2120  			       const struct nft_pipapo_match *m,
3c4287f62044a90 Stefano Brivio    2020-01-22  2121  			       struct nft_set_iter *iter)
3c4287f62044a90 Stefano Brivio    2020-01-22 @2122  {
f04df573faf90bb Florian Westphal  2024-02-13  2123  	const struct nft_pipapo_field *f;
aac14d516c2b575 Florian Westphal  2024-02-13  2124  	unsigned int i, r;
3c4287f62044a90 Stefano Brivio    2020-01-22  2125  
3c4287f62044a90 Stefano Brivio    2020-01-22  2126  	for (i = 0, f = m->f; i < m->field_count - 1; i++, f++)
3c4287f62044a90 Stefano Brivio    2020-01-22  2127  		;
3c4287f62044a90 Stefano Brivio    2020-01-22  2128  
3c4287f62044a90 Stefano Brivio    2020-01-22  2129  	for (r = 0; r < f->rules; r++) {
3c4287f62044a90 Stefano Brivio    2020-01-22  2130  		struct nft_pipapo_elem *e;
3c4287f62044a90 Stefano Brivio    2020-01-22  2131  
3c4287f62044a90 Stefano Brivio    2020-01-22  2132  		if (r < f->rules - 1 && f->mt[r + 1].e == f->mt[r].e)
3c4287f62044a90 Stefano Brivio    2020-01-22  2133  			continue;
3c4287f62044a90 Stefano Brivio    2020-01-22  2134  
3c4287f62044a90 Stefano Brivio    2020-01-22  2135  		if (iter->count < iter->skip)
3c4287f62044a90 Stefano Brivio    2020-01-22  2136  			goto cont;
3c4287f62044a90 Stefano Brivio    2020-01-22  2137  
3c4287f62044a90 Stefano Brivio    2020-01-22  2138  		e = f->mt[r].e;
3c4287f62044a90 Stefano Brivio    2020-01-22  2139  
0e1ea651c9717dd Pablo Neira Ayuso 2023-10-16  2140  		iter->err = iter->fn(ctx, set, iter, &e->priv);
3c4287f62044a90 Stefano Brivio    2020-01-22  2141  		if (iter->err < 0)
cd491237776df45 Florian Westphal  2024-04-25  2142  			return;
3c4287f62044a90 Stefano Brivio    2020-01-22  2143  
3c4287f62044a90 Stefano Brivio    2020-01-22  2144  cont:
3c4287f62044a90 Stefano Brivio    2020-01-22  2145  		iter->count++;
3c4287f62044a90 Stefano Brivio    2020-01-22  2146  	}
cd491237776df45 Florian Westphal  2024-04-25  2147  }
3c4287f62044a90 Stefano Brivio    2020-01-22  2148  

:::::: The code at line 2122 was first introduced by commit
:::::: 3c4287f62044a90e73a561aa05fc46e62da173da nf_tables: Add set type for arbitrary concatenation of ranges

:::::: TO: Stefano Brivio <sbrivio@redhat.com>
:::::: CC: Pablo Neira Ayuso <pablo@netfilter.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2024-05-03  8:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  8:03 kernel test robot [this message]
2024-05-03 10:41 ` [netfilter-nf:under-review 14/18] net/netfilter/nft_set_pipapo.c:2122: warning: expecting prototype for __nft_pipapo_walk(). Prototype was for nft_pipapo_do_walk() instead Florian Westphal
2024-05-06  9:10   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405031522.nDHvTzEz-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pablo@netfilter.org \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).