From: Florian Westphal <fw@strlen.de>
To: Antonio Ojea <aojea@google.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org, fw@strlen.de
Subject: Re: [PATCH v2 1/2] netfilter: nft_queue: compute SCTP checksum
Date: Mon, 13 May 2024 23:14:29 +0200 [thread overview]
Message-ID: <20240513211429.GA17004@breakpoint.cc> (raw)
In-Reply-To: <20240513000953.1458015-2-aojea@google.com>
Antonio Ojea <aojea@google.com> wrote:
> when packet is enqueued with nfqueue and GSO is enabled, checksum
> calculation has to take into account the protocol, as SCTP uses a
> 32 bits CRC checksum.
>
> Signed-off-by: Antonio Ojea <aojea@google.com>
> ---
> V1 -> V2: add a helper function to process the checksum
>
> net/netfilter/nfnetlink_queue.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
> index 00f4bd21c59b..accf4942d9ff 100644
> --- a/net/netfilter/nfnetlink_queue.c
> +++ b/net/netfilter/nfnetlink_queue.c
> @@ -538,6 +538,14 @@ static int nfqnl_put_bridge(struct nf_queue_entry *entry, struct sk_buff *skb)
> return -1;
> }
>
> +static int nf_queue_checksum_help(struct sk_buff *entskb)
> +{
> + if (skb_csum_is_sctp(entskb))
> + return skb_crc32c_csum_help(entskb);
This should be tabs, please run your patch through checkpatch.pl.
next prev parent reply other threads:[~2024-05-13 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 0:09 [PATCH v2 0/2] netfilter: nfqueue: incorrect sctp checksum Antonio Ojea
2024-05-13 0:09 ` [PATCH v2 1/2] netfilter: nft_queue: compute SCTP checksum Antonio Ojea
2024-05-13 21:14 ` Florian Westphal [this message]
2024-05-13 0:09 ` [PATCH v2 2/2] selftests: net: netfilter: nft_queue.sh: sctp checksum Antonio Ojea
2024-05-13 21:18 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513211429.GA17004@breakpoint.cc \
--to=fw@strlen.de \
--cc=aojea@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).