From: Michael Estner <michaelestner@web.de>
To: netfilter-devel@vger.kernel.org
Cc: Michael Estner <michaelestner@web.de>
Subject: [PATCH] iptables: cleanup FIXME
Date: Thu, 23 May 2024 16:50:58 +0200 [thread overview]
Message-ID: <20240523145058.747280-1-michaelestner@web.de> (raw)
Remove obsolet FIXME since struct ebt_entry has no flags var.
Update the debug output.
Signed-off-by: Michael Estner <michaelestner@web.de>
---
iptables/nft-bridge.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/iptables/nft-bridge.c b/iptables/nft-bridge.c
index 922ce983..f5deaa93 100644
--- a/iptables/nft-bridge.c
+++ b/iptables/nft-bridge.c
@@ -373,9 +373,8 @@ static bool nft_bridge_is_same(const struct iptables_command_state *cs_a,
int i;
if (a->ethproto != b->ethproto ||
- /* FIXME: a->flags != b->flags || */
a->invflags != b->invflags) {
- DEBUGP("different proto/flags/invflags\n");
+ DEBUGP("different proto/invflags\n");
return false;
}
--
2.25.1
next reply other threads:[~2024-05-23 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 14:50 Michael Estner [this message]
2024-05-23 16:45 ` [PATCH] iptables: cleanup FIXME Phil Sutter
[not found] <Zk9yrd8Ji1xAcblw>
2024-05-24 13:24 ` Michael Estner
2024-05-24 13:24 ` Michael Estner
2024-05-26 9:50 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523145058.747280-1-michaelestner@web.de \
--to=michaelestner@web.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).