From: Florian Westphal <fw@strlen.de>
To: wangyunjian <wangyunjian@huawei.com>
Cc: Florian Westphal <fw@strlen.de>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
xudingke <xudingke@huawei.com>
Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type
Date: Thu, 30 May 2024 09:52:20 +0200 [thread overview]
Message-ID: <20240530075220.GA19949@breakpoint.cc> (raw)
In-Reply-To: <d6a7fe4b75b14cdda1a259c2acb10766@huawei.com>
wangyunjian <wangyunjian@huawei.com> wrote:
> > -----Original Message-----
> > From: Florian Westphal [mailto:fw@strlen.de]
> > Sent: Wednesday, May 29, 2024 8:03 PM
> > To: wangyunjian <wangyunjian@huawei.com>
> > Cc: netfilter-devel@vger.kernel.org; pablo@netfilter.org; kadlec@netfilter.org;
> > kuba@kernel.org; davem@davemloft.net; coreteam@netfilter.org; xudingke
> > <xudingke@huawei.com>
> > Subject: Re: [PATCH net] netfilter: nf_conncount: fix wrong variable type
> >
> > Yunjian Wang <wangyunjian@huawei.com> wrote:
> > > 'keylen' is supposed to be unsigned int, not u8, so fix it.
> >
> > Its limited to 5, so u8 works fine.
>
> Currently, it does not affect the functionality. The main issue is that code
> checks will report a warning: implicit narrowing conversion from type
> 'unsigned int' to small type 'u8'.
Then please quote the exact warning in the commit message and remove the
u8 temporary variable in favor of data->keylen.
next prev parent reply other threads:[~2024-05-30 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 1:40 [PATCH net] netfilter: nf_conncount: fix wrong variable type Yunjian Wang
2024-05-29 12:02 ` Florian Westphal
2024-05-30 3:02 ` wangyunjian
2024-05-30 7:52 ` Florian Westphal [this message]
2024-05-30 9:42 ` wangyunjian
2024-05-30 13:13 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530075220.GA19949@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).