From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail115-69.sinamail.sina.com.cn (mail115-69.sinamail.sina.com.cn [218.30.115.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B0EF17332B for ; Wed, 3 Jul 2024 12:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.30.115.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720008609; cv=none; b=PMurby7rU2xd3IHHVXIdpHvJns0Wtsf63joRUai+erwadftqjgdM4DaGu+YzlozoUDOQe6iLyrR70JNxwp4CANGMNZLGpMt3IaUm32FX/Py/cUnvAAx9o3V4o5niWlvMipTaolKLvJliqv5VZEFIK1/7r4AM7ilSUeFLXkdaziw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720008609; c=relaxed/simple; bh=2aCGqVBTsyNtk/3i1tyo0SCfBtdeq6gmjEv8SUq1xp8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g9CNa7nhikng/WAUGvbKeejFdjv8fGyHNYZOVMJrQ0jgm41SLz3/O9eq+v8vH0A5sYBMptPuRREWtD/RV+PV6orJpfuIM7f0e3FuePx/nRA7WbMosNldlQuVy59LhDWCVlg8VWUSuUKcw8VH2JOesulJDfuWeUonkIsmtzFuY38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=218.30.115.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.64.67]) by sina.com (10.185.250.22) with ESMTP id 66853F73000021A1; Wed, 3 Jul 2024 20:09:27 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 7016087602759 X-SMAIL-UIID: 10971053EF6F4499A16CF27989682586-20240703-200927-1 From: Hillf Danton To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+4fd66a69358fc15ae2ad@syzkaller.appspotmail.com Subject: Re: [PATCH nf] netfilter: nf_tables: unconditionally flush pending work before notifier Date: Wed, 3 Jul 2024 20:09:13 +0800 Message-Id: <20240703120913.2981-1-hdanton@sina.com> In-Reply-To: <20240703105215.GA26857@breakpoint.cc> References: <20240702140841.3337-1-fw@strlen.de> <20240703103544.2872-1-hdanton@sina.com> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 3 Jul 2024 12:52:15 +0200 Florian Westphal > Hillf Danton wrote: > > Given trans->table goes thru the lifespan of trans, your proposal is a bandaid > > if trans outlives table. > > trans must never outlive table. > What is preventing trans from being freed after closing sock, given trans is freed in workqueue? close sock queue work