From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27E91C6F67 for ; Thu, 10 Oct 2024 12:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728564433; cv=none; b=NtATiNXRLi6AlxWM0FfZ9mbpukaNh0+mPL4vsr4nl+zDbpvEz+M2wORyMCFHXVQH3t2QuZBn4/Dx3yYVt35zA1nW+WAPFxOh6DmTWgI//xBTQdOEA0Y3XktfX9WfQnm9+fFbTvltANo4dmqlRFQqviFtA4O81zo+bjpGrfqjwFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728564433; c=relaxed/simple; bh=byKPRSdbCbqfPFsx4nv8oJaMRDo5VkIdMcx/SEc8k+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FNs729bigCl/OUnrBI8/uFOwkdJVZxPE2OkHWZKz36xEv5fhsM0uUWg1pBC8V3noMH/5/9qwTjvp5PsR3PYHWePOVuKTPXM2WIA53wPzdq6Wf36bc4PflZ127Lku+Psf/mcgvXn/w4pmT/BXqBVsw4qoSwd+An0N6EOFGD5W2Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1sysZQ-0000OO-VQ; Thu, 10 Oct 2024 14:47:08 +0200 Date: Thu, 10 Oct 2024 14:47:08 +0200 From: Florian Westphal To: Yadan Fan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, Michal Kubecek , Hannes Reinecke Subject: Re: [PATCH] nf_conntrack_proto_udp: Set ASSURED for NAT_CLASH entries to avoid packets dropped Message-ID: <20241010124708.GB30424@breakpoint.cc> References: Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Yadan Fan wrote: > c46172147ebb brought the logic that never setting ASSURED to drop NAT_CLASH replies > in case server is very busy and early_drop logic kicks in. > > However, this will drop all subsequent UDP packets that sent through multiple threads > of application, we already had a customer reported this issue that impacts their business, > so deleting this logic to avoid this issue at the moment. > > Fixes: c46172147ebb ("netfilter: conntrack: do not auto-delete clash entries on reply") > > Signed-off-by: Yadan Fan Acked-by: Florian Westphal