From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: shell: fix spurious dump failure in vmap timeout test
Date: Fri, 11 Oct 2024 11:15:08 +0200 [thread overview]
Message-ID: <20241011091508.GA8212@breakpoint.cc> (raw)
In-Reply-To: <ZwjkK0IXn0GGVCfm@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> > utimeout=$((RANDOM%5))
> > - utimeout=$((timeout+1))
> > + utimeout=$((utimeout+1))
>
> How about merging the statements?
>
> | utimeout=$((RANDOM % 5 + 1))
Sure, that works too. I applied the patch as-is, you can munge this as
a followup if you like.
prev parent reply other threads:[~2024-10-11 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 0:32 [PATCH nft] tests: shell: fix spurious dump failure in vmap timeout test Florian Westphal
2024-10-11 8:39 ` Phil Sutter
2024-10-11 9:15 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011091508.GA8212@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).