From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF4C6209F51 for ; Fri, 11 Oct 2024 09:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728638113; cv=none; b=mz1gPvvutpNMsL5csVEL8EIcQsAznKbZBirJbiX2170NQApmSveYkCc84xWSk/7jrSlG0rzQ+IGet7M9ry8M1qied9K4pfLkhrW6SJIOYJrJ+ztPTWSmG0fuH7B22fuUvBnJeBiYUVDuIwo8gqCJQERmrqSIZnhNzuBiM8Wh04k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728638113; c=relaxed/simple; bh=FoSECjR/1N06avgIXgqkPbluUarT+aCaFioSw8lzI9g=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eUSwVWIh5vxlR6fH8wrB5s24laetoTGrmmeHeGeVHI4wJG8BpSOIm/HCJp13frnXW4W66/RjrFAXZc78hJPgsw1fc3vTcyndPetiLoT+HUB7KZAxEkV+bEdS1rMA8k+291u3nLa2QbbyZtJxJM1E4zMD4Qk20BdBHgywj8ZAy8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1szBjo-00029C-9N; Fri, 11 Oct 2024 11:15:08 +0200 Date: Fri, 11 Oct 2024 11:15:08 +0200 From: Florian Westphal To: Phil Sutter , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] tests: shell: fix spurious dump failure in vmap timeout test Message-ID: <20241011091508.GA8212@breakpoint.cc> References: <20241011003211.4780-1-fw@strlen.de> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Phil Sutter wrote: > > utimeout=$((RANDOM%5)) > > - utimeout=$((timeout+1)) > > + utimeout=$((utimeout+1)) > > How about merging the statements? > > | utimeout=$((RANDOM % 5 + 1)) Sure, that works too. I applied the patch as-is, you can munge this as a followup if you like.