Linux Netfilter development
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Florian Westphal <fw@strlen.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Phil Sutter <phil@nwl.cc>,
	coreteam@netfilter.org
Subject: Re: Netfilter: suspicious RCU usage in __nft_rule_lookup
Date: Fri, 25 Oct 2024 11:23:56 +0200	[thread overview]
Message-ID: <20241025092356.GA11843@breakpoint.cc> (raw)
In-Reply-To: <40d071e1-4c13-49c9-8cac-14c1377eaf86@kernel.org>

Matthieu Baerts <matttbe@kernel.org> wrote:
> While at it, I had a question related to the rules' list: in
> __nft_release_basechain() from the same nf_tables_api.c file, list's
> entries are not removed with the _rcu variant → is it OK to do that
> because this function is only called last at the cleanup time, when no
> other readers can iterate over the list? So similar to what is done in
> __nft_release_table()?

Looks like __nft_release_basechain() is broken from start, I don't see
how it can work, it doesn't call synchronize_rcu or anything like that
afaics.

No idea what to do here.

  reply	other threads:[~2024-10-25  9:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 16:56 Netfilter: suspicious RCU usage in __nft_rule_lookup Matthieu Baerts
2024-10-24 17:35 ` Florian Westphal
2024-10-24 18:00   ` Pablo Neira Ayuso
2024-10-24 17:57 ` Pablo Neira Ayuso
2024-10-24 18:20   ` Pablo Neira Ayuso
2024-10-24 23:22     ` Florian Westphal
2024-10-25  8:14       ` Matthieu Baerts
2024-10-25  9:23         ` Florian Westphal [this message]
2024-10-25  9:42           ` Pablo Neira Ayuso
2024-10-25  9:46           ` Phil Sutter
2024-10-25 10:26             ` Pablo Neira Ayuso
2024-10-25 10:56               ` Phil Sutter
2024-10-25 11:43                 ` Pablo Neira Ayuso
2024-10-25 13:16                   ` Pablo Neira Ayuso
2024-10-25 10:35       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025092356.GA11843@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=coreteam@netfilter.org \
    --cc=kadlec@netfilter.org \
    --cc=matttbe@kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox