From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
Nadia Pinaeva <n.m.pinaeva@gmail.com>,
netfilter-devel@vger.kernel.org,
Antonio Ojea <antonio.ojea.garcia@gmail.com>
Subject: Re: [PATCH nf-next v2] netfilter: conntrack: collect start time as early as possible
Date: Wed, 6 Nov 2024 09:26:44 +0100 [thread overview]
Message-ID: <20241106082644.GA474@breakpoint.cc> (raw)
In-Reply-To: <ZyqoReoNkhz_fo3p@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Tue, Nov 05, 2024 at 06:32:47PM +0100, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > Thanks, I'd rather convince you this is the way to go, if after
> > > quickly sketching a patchset you think it is not worth for more
> > > reasons, we can revisit.
> >
> > Untested. I'm not sure about skb_tstamp() usage.
> > As-is CTA_EVENT_TIMESTAMP in the NEW event would be before
> > the start time reported as the start time by the timestamp extension.
>
> Is there any chance this timestamp can be enabled via toggle?
Can you clarify? Do you mean skb_tstamp() vs ktime_get_real_ns()
or tstamp sampling in general?
> > + CTA_EVENT_TIMESTAMP,
>
> CTA_TIMESTAMP_EVENT
>
> for consistency with CTA_TIMESTAMP_{START,...}
Sure, updated.
next prev parent reply other threads:[~2024-11-06 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 13:12 [PATCH nf-next v2] netfilter: conntrack: collect start time as early as possible Florian Westphal
2024-11-03 10:26 ` Nadia Pinaeva
2024-11-04 9:09 ` Pablo Neira Ayuso
2024-11-04 9:39 ` Florian Westphal
2024-11-04 10:03 ` Nadia Pinaeva
2024-11-04 11:09 ` Antonio Ojea
2024-11-05 16:08 ` Pablo Neira Ayuso
2024-11-05 16:23 ` Florian Westphal
2024-11-05 16:28 ` Pablo Neira Ayuso
2024-11-05 16:33 ` Florian Westphal
2024-11-05 16:45 ` Pablo Neira Ayuso
2024-11-05 17:32 ` Florian Westphal
2024-11-05 23:20 ` Pablo Neira Ayuso
2024-11-06 8:26 ` Florian Westphal [this message]
2024-11-06 8:32 ` Pablo Neira Ayuso
2024-11-06 8:34 ` Florian Westphal
2024-11-06 9:10 ` Pablo Neira Ayuso
2024-11-06 12:39 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106082644.GA474@breakpoint.cc \
--to=fw@strlen.de \
--cc=antonio.ojea.garcia@gmail.com \
--cc=n.m.pinaeva@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox