From: Jeremy Sowden <azazel@debian.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: James Dingwall <james@dingwall.me.uk>, netfilter-devel@vger.kernel.org
Subject: Re: ulogd: out of bounds array access in ulogd_filter_HWHDR
Date: Mon, 13 Jan 2025 12:32:25 +0000 [thread overview]
Message-ID: <20250113123225.GC2068886@celephais.dreamlands> (raw)
In-Reply-To: <Z4UHMxttvdFs55Vo@calendula>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On 2025-01-13, at 13:30:01 +0100, Pablo Neira Ayuso wrote:
> On Mon, Jan 13, 2025 at 11:12:01AM +0000, Jeremy Sowden wrote:
> > On 2025-01-13, at 10:33:10 +0000, James Dingwall wrote:
> [...]
> > > --- filter/ulogd_filter_HWHDR.c.orig 2025-01-13 09:25:18.937977335 +0000
> > > +++ filter/ulogd_filter_HWHDR.c 2025-01-13 09:25:51.337824820 +0000
> > > @@ -109,7 +109,7 @@
> > > },
> > > };
> > >
> > > -static char hwmac_str[MAX_KEY - START_KEY][HWADDR_LENGTH];
> > > +static char hwmac_str[(MAX_KEY + 1) - START_KEY][HWADDR_LENGTH];
> > >
> > > static int parse_mac2str(struct ulogd_key *ret, unsigned char *mac,
> > > int okey, int len)
> >
> > This was fixed a couple of years ago:
> >
> > https://git.netfilter.org/ulogd2/commit/?id=49f6def6fcbaf01f395fbe00543a9ab2c4bb106e
> >
> > and the fix should have made it into the Debian & Ubuntu packages. I
> > will investigate.
>
> I am going to launch a new release to help this propagate to distros.
Thanks, Pablo. I was going to request one. :)
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 931 bytes --]
next prev parent reply other threads:[~2025-01-13 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 10:33 ulogd: out of bounds array access in ulogd_filter_HWHDR James Dingwall
2025-01-13 11:12 ` Jeremy Sowden
2025-01-13 12:30 ` Pablo Neira Ayuso
2025-01-13 12:32 ` Jeremy Sowden [this message]
2025-01-13 22:23 ` bugzilla forbiden issue [was Re: ulogd: out of bounds array access in ulogd_filter_HWHDR] Pablo Neira Ayuso
2025-01-14 0:29 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113123225.GC2068886@celephais.dreamlands \
--to=azazel@debian.org \
--cc=james@dingwall.me.uk \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).