[PATCH] configure: Avoid addition assignment operators

[PATCH] configure: Avoid addition assignment operators

[fossdd]

For compatability with other /bin/sh like busybox ash, since they don't
support the addition assignment operators (+=) and otherwise fail with:

	./configure: line 14174: regular_CFLAGS+= -D__UAPI_DEF_ETHHDR=0: not found

Signed-off-by: fossdd <fossdd@pwned.life>
---
 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2d38a4d4..0106b316 100644
--- a/configure.ac
+++ b/configure.ac
@@ -202,8 +202,8 @@ fi;
 pkgdatadir='${datadir}/xtables';
 
 if test "x$enable_profiling" = "xyes"; then
-	regular_CFLAGS+=" -fprofile-arcs -ftest-coverage"
-	regular_LDFLAGS+=" -lgcov --coverage"
+	regular_CFLAGS="$regular_CFLAGS -fprofile-arcs -ftest-coverage"
+	regular_LDFLAGS="$regular_LDFLAGS -lgcov --coverage"
 fi
 
 AC_MSG_CHECKING([whether the build is using musl-libc])
@@ -222,7 +222,7 @@ AC_COMPILE_IFELSE(
 AC_MSG_RESULT([${enable_musl_build}])
 
 if test "x$enable_musl_build" = "xyes"; then
-	regular_CFLAGS+=" -D__UAPI_DEF_ETHHDR=0"
+	regular_CFLAGS="$regular_CFLAGS -D__UAPI_DEF_ETHHDR=0"
 fi
 
 define([EXPAND_VARIABLE],

base-commit: b3f3e256c263b9a1db49732696aba0dde084ef5e
-- 
2.48.0

Re: [PATCH] configure: Avoid addition assignment operators

[Pablo Neira Ayuso]

On Mon, Jan 13, 2025 at 04:08:34PM +0100, fossdd wrote:
> For compatability with other /bin/sh like busybox ash, since they don't
> support the addition assignment operators (+=) and otherwise fail with:
> 
> 	./configure: line 14174: regular_CFLAGS+= -D__UAPI_DEF_ETHHDR=0: not found
> 
> Signed-off-by: fossdd <fossdd@pwned.life>

This solution looks OK to address the musl issue that we have
discussed.

Unfortunately, we don't take patches that abuse DCO via Signed-off-by:
that looks clearly made up.

Re: [PATCH] configure: Avoid addition assignment operators

[fossdd]

> Unfortunately, we don't take patches that abuse DCO via Signed-off-by:
> that looks clearly made up.

I can resend a v2 with my full name as commit author and Signed-off-by,
if thats what you're asking.

Re: [PATCH] configure: Avoid addition assignment operators

[fossdd]

On Tue Jan 14, 2025 at 3:56 AM CET, fossdd wrote:
>> Unfortunately, we don't take patches that abuse DCO via Signed-off-by:
>> that looks clearly made up.
>
> I can resend a v2 with my full name as commit author and Signed-off-by,
> if thats what you're asking.

Ping

Re: [PATCH] configure: Avoid addition assignment operators

[Jeremy Sowden]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On 2025-01-26, at 18:13:59 +0100, fossdd wrote:
> On Tue Jan 14, 2025 at 3:56 AM CET, fossdd wrote:
> >> Unfortunately, we don't take patches that abuse DCO via Signed-off-by:
> >> that looks clearly made up.
> >
> > I can resend a v2 with my full name as commit author and Signed-off-by,
> > if thats what you're asking.

Yes, please.

> Ping

J.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 931 bytes --]