From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de
Subject: [PATCH nft,v2 3/3] tests: extend reset test case to cover interval set and map type
Date: Thu, 6 Mar 2025 19:28:12 +0100 [thread overview]
Message-ID: <20250306182812.330871-3-pablo@netfilter.org> (raw)
In-Reply-To: <20250306182812.330871-1-pablo@netfilter.org>
From: Florian Westphal <fw@strlen.de>
Make sure segtree processing doesn't drop associated stateful elements.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
v2: add map tests.
tests/shell/testcases/sets/reset_command_0 | 70 ++++++++++++++++++----
1 file changed, 60 insertions(+), 10 deletions(-)
diff --git a/tests/shell/testcases/sets/reset_command_0 b/tests/shell/testcases/sets/reset_command_0
index d38ddb3ffeeb..c59cc56d20b8 100755
--- a/tests/shell/testcases/sets/reset_command_0
+++ b/tests/shell/testcases/sets/reset_command_0
@@ -17,6 +17,19 @@ RULESET="table t {
2.0.0.2 . tcp . 22 counter packets 10 bytes 100 timeout 15m expires 10m
}
}
+
+ set s2 {
+ type ipv4_addr
+ flags interval, timeout
+ counter
+ timeout 30m
+ elements = {
+ 1.0.0.1 counter packets 5 bytes 30 expires 20m,
+ 1.0.1.1-1.0.1.10 counter packets 5 bytes 30 expires 20m,
+ 2.0.0.2 counter packets 10 bytes 100 timeout 15m expires 10m
+ }
+ }
+
map m {
type ipv4_addr : ipv4_addr
quota 50 bytes
@@ -25,6 +38,27 @@ RULESET="table t {
5.6.7.8 quota 100 bytes used 50 bytes : 50.6.7.8
}
}
+
+ map m1 {
+ type ipv4_addr : ipv4_addr
+ counter
+ timeout 30m
+ elements = {
+ 1.2.3.4 counter packets 5 bytes 30 expires 20m : 10.2.3.4,
+ 5.6.7.8 counter packets 10 bytes 100 timeout 15m expires 10m : 50.6.7.8
+ }
+ }
+
+ map m2 {
+ type ipv4_addr : ipv4_addr
+ flags interval, timeout
+ counter
+ timeout 30m
+ elements = {
+ 1.2.3.4-1.2.3.10 counter packets 5 bytes 30 expires 20m : 10.2.3.4,
+ 5.6.7.8-5.6.7.10 counter packets 10 bytes 100 timeout 15m expires 10m : 50.6.7.8
+ }
+ }
}"
echo -n "applying test ruleset: "
@@ -38,17 +72,33 @@ expires_minutes() {
sed -n 's/.*expires \([0-9]*\)m.*/\1/p'
}
-echo -n "get set elem matches reset set elem: "
-elem='element t s { 1.0.0.1 . udp . 53 }'
-[[ $($NFT "get $elem ; reset $elem" | \
- grep 'elements = ' | drop_seconds | uniq | wc -l) == 1 ]]
-echo OK
+get_and_reset()
+{
+ local setname="$1"
+ local key="$2"
-echo -n "counters are reset, expiry left alone: "
-NEW=$($NFT "get $elem")
-grep -q 'counter packets 0 bytes 0' <<< "$NEW"
-[[ $(expires_minutes <<< "$NEW") -lt 20 ]]
-echo OK
+ echo -n "get set elem matches reset set elem in set $setname: "
+
+ elem="element t $setname { $key }"
+ echo $NFT get $elem
+ $NFT get $elem
+ [[ $($NFT "get $elem ; reset $elem" | \
+ grep 'elements = ' | drop_seconds | uniq | wc -l) == 1 ]]
+ echo OK
+
+ echo -n "counters are reset, expiry left alone in set $setname: "
+ NEW=$($NFT "get $elem")
+ echo NEW $NEW
+ grep -q 'counter packets 0 bytes 0' <<< "$NEW"
+ [[ $(expires_minutes <<< "$NEW") -lt 20 ]]
+ echo OK
+}
+
+get_and_reset "s" "1.0.0.1 . udp . 53"
+get_and_reset "s2" "1.0.0.1"
+get_and_reset "s2" "1.0.1.1-1.0.1.10"
+get_and_reset "m1" "1.2.3.4"
+get_and_reset "m2" "1.2.3.4-1.2.3.10"
echo -n "get map elem matches reset map elem: "
elem='element t m { 1.2.3.4 }'
--
2.30.2
next prev parent reply other threads:[~2025-03-06 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 18:28 [PATCH nft,v2 1/3] src: fix reset element support for interval set type Pablo Neira Ayuso
2025-03-06 18:28 ` [PATCH nft,v2 2/3] segtree: incomplete output in get element command with maps Pablo Neira Ayuso
2025-03-06 18:28 ` Pablo Neira Ayuso [this message]
2025-03-07 11:16 ` [PATCH nft,v2 1/3] src: fix reset element support for interval set type Florian Westphal
2025-03-07 12:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306182812.330871-3-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).