From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E201E8335 for ; Wed, 12 Mar 2025 18:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741805722; cv=none; b=AD2J2BbhP8ES4bCTiqGKLzB5CTudObt+qecHlEnfRhNi5UdMwHX5etwu5y1mgtQp+uOtXEgASS8ojjPFEQcc3CVY/ceHoG1fnV/iGLA/b9o9P84sY8rGrzLX4SfjSRICgEfC0LSkvTNkf7zOpO3OqvP3pgb7CqIMXk40/00jq8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741805722; c=relaxed/simple; bh=cM5OHMrIwGn+/h/3YXeX7Kjk2y2LUgvOMKtthhLuaPQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jgY+mhsed8pMoul1RYME3gS2tQl0S0ERpXtSeqa2Wr2jQruAGdf0TfOS18DjjvhQtIMksxnGUDi6xU+M3HiSzvX/plaQMm1J4EPDjbefcvFJ5bvFB7E/S7hJ0bXdPVri+d8/lJfw8zRUOUiBTj0RrqLLwhsLBkMS6MTvn2NaDvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1tsREc-00017E-1I; Wed, 12 Mar 2025 19:55:18 +0100 Date: Wed, 12 Mar 2025 19:55:18 +0100 From: Florian Westphal To: Corubba Smith Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH ulogd2,v2 3/6] ulogd: raise error on unknown config key Message-ID: <20250312185518.GA4233@breakpoint.cc> References: <1a5fff4d-4cef-48e3-a77c-bb4f7098f35b@gmx.de> <20250312152154.GA28069@breakpoint.cc> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Corubba Smith wrote: > So my proposed fix would be: > > - strncpy(&config_errce->key[0], wordbuf, CONFIG_KEY_LEN - 1); > + memcpy(&config_errce->key[0], wordbuf, sizeof(config_errce->key) - 1); > > Compiles without a warning, and tested to work as expected. Would you > like a v3 of the whole patch, or is this addendum good enough? Please rebase and send a v3.