From: Florian Westphal <fw@strlen.de>
To: Antonio Ojea <aojea@google.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Eric Dumazet <edumazet@google.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: netfilter: conntrack respect reject rules
Date: Mon, 17 Mar 2025 14:19:55 +0100 [thread overview]
Message-ID: <20250317131955.GA5110@breakpoint.cc> (raw)
In-Reply-To: <20250314092837.3381916-1-aojea@google.com>
Antonio Ojea <aojea@google.com> wrote:
> + # request from ns1 to vip (DNAT to ns2) on an existing connection
> + # if we don't read from the pipe the traffic loops forever
> + echo PING2 >> "$TMPFILEIN"
> + sleep 0.5
This doesn't really work, 0.5 is too low for my machine
and the tests fail most of the time.
Can you rework this to use the busywait helper
instead of sleep?
The checks are also very repetitive, so there is potential
for code reuse.
Thanks.
next prev parent reply other threads:[~2025-03-17 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 23:13 [PATCH] selftests: netfilter: conntrack respect reject rules Antonio Ojea
2025-03-14 9:28 ` [PATCH v2] " Antonio Ojea
2025-03-17 13:19 ` Florian Westphal [this message]
2025-03-18 9:41 ` [PATCH v3] " Antonio Ojea
2025-03-18 13:23 ` Florian Westphal
2025-03-18 16:35 ` [PATCH v4] " Antonio Ojea
2025-03-18 20:04 ` Florian Westphal
2025-03-23 10:02 ` Pablo Neira Ayuso
2025-03-23 11:08 ` Antonio Ojea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317131955.GA5110@breakpoint.cc \
--to=fw@strlen.de \
--cc=aojea@google.com \
--cc=edumazet@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).