From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] expression: tolerate named set protocol dependency
Date: Thu, 20 Mar 2025 09:30:08 +0100 [thread overview]
Message-ID: <20250320083008.GB1543@breakpoint.cc> (raw)
In-Reply-To: <Z9teyXKA-B25J2mO@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > + const struct expr *key = right->set->key;
> > + struct expr *tmp;
> > +
> > + tmp = constant_expr_alloc(&expr->location, key->dtype,
> > + key->byteorder, key->len,
> > + NULL);
> > +
> > + ops->pctx_update(ctx, &expr->location, left, tmp);
> > + expr_free(tmp);
>
> maybe narrow down this to meta on the lhs? I am not sure of the effect
> of this update for payload and ct, they also provide .pctx_update.
Sure, I can amend it accordingly.
> If there is a use-case for these two other expression, this can be
> revisited.
Agreed, lets restrict it for meta for now.
Thanks for reviewing.
prev parent reply other threads:[~2025-03-20 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 16:39 [PATCH nft] expression: tolerate named set protocol dependency Florian Westphal
2025-03-20 0:18 ` Pablo Neira Ayuso
2025-03-20 8:30 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320083008.GB1543@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).