netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Corubba Smith <corubba@gmx.de>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2] nfct: fix counter-reset without hashtable
Date: Tue, 25 Mar 2025 11:35:48 +0100	[thread overview]
Message-ID: <20250325103548.GC4481@breakpoint.cc> (raw)
In-Reply-To: <fb5de8d9-f106-4352-907a-461f3323ac88@gmx.de>

Corubba Smith <corubba@gmx.de> wrote:
> On 3/25/25 06:56, Florian Westphal wrote:
> > Corubba Smith <corubba@gmx.de> wrote:
> >> The dump_reset_handler will try to update the hashtable regardless of
> >> whether it is used (and thus initialized), which results in a segfault
> >> if it isn't. Instead just short-circuit the handler, and skip any
> >> further result processing because it's not used in this case anyway.
> >> All flow counters in conntrack are reset regardless of the return value
> >> of the handler/callback.
> >
> > How can this happen?
> > constructor_nfct (->start()) will return an error if ct_active table
> > cannot be allocated/is disabled?
> >
> 
> In event mode the hashtable is optional, and sending SIGUSR2 to ulogd will
> call get_ctr_zero().

Thanks, applied the patch with above sentence included in the commit
message.

      reply	other threads:[~2025-03-25 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  0:24 [PATCH ulogd2] nfct: fix counter-reset without hashtable Corubba Smith
2025-03-25  5:56 ` Florian Westphal
2025-03-25  9:20   ` Corubba Smith
2025-03-25 10:35     ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250325103548.GC4481@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=corubba@gmx.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).