From: Florian Westphal <fw@strlen.de>
To: Corubba Smith <corubba@gmx.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2,v2 3/4] nflog: add network namespace support
Date: Wed, 26 Mar 2025 20:27:01 +0100 [thread overview]
Message-ID: <20250326192701.GB2205@breakpoint.cc> (raw)
In-Reply-To: <0e7e461d-a30a-42af-9427-96cd97eb108d@gmx.de>
Corubba Smith <corubba@gmx.de> wrote:
> + if ((strlen(target_netns_path) > 0) &&
> + (join_netns_fd(source_netns_fd, NULL) != ULOGD_IRET_OK)
> + ) {
> + ulogd_log(ULOGD_FATAL, "error joining source network "
> + "namespace\n");
> + goto out_handle;
> + }
> + source_netns_fd = -1;
> +
This looks buggy, but I do realize that join_netns_fd() closes this
for us.
Maybe a comment would help?
next prev parent reply other threads:[~2025-03-26 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 1:05 [PATCH ulogd2,v2 1/4] ulogd: add linux namespace helper Corubba Smith
2025-03-25 1:07 ` [PATCH ulogd2,v2 2/4] nfct: add network namespace support Corubba Smith
2025-03-25 1:08 ` [PATCH ulogd2,v2 3/4] nflog: " Corubba Smith
2025-03-26 19:27 ` Florian Westphal [this message]
2025-03-25 1:09 ` [PATCH ulogd2,v2 4/4] nfacct: " Corubba Smith
2025-03-26 19:23 ` [PATCH ulogd2,v2 1/4] ulogd: add linux namespace helper Florian Westphal
2025-04-10 20:02 ` Corubba Smith
2025-04-11 20:06 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326192701.GB2205@breakpoint.cc \
--to=fw@strlen.de \
--cc=corubba@gmx.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).