From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: tolerate empty concatenation
Date: Thu, 27 Mar 2025 16:49:10 +0100 [thread overview]
Message-ID: <20250327154910.GB21843@breakpoint.cc> (raw)
In-Reply-To: <Z-VxdrgTRO1RTdBq@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Mar 24, 2025 at 12:52:58PM +0100, Florian Westphal wrote:
> > > Don't rely on a successful evaluation of set->key.
> > > With this input, set->key fails validation but subsequent
> > > element evaluation asserts because the context points at
> > > the set key -- an empty concatenation.
> > >
> > > Causes:
> > > nft: src/evaluate.c:1681: expr_evaluate_concat: Assertion `!list_empty(&ctx->ectx.key->expressions)' failed.
> > >
> > > After patch:
> > > internal:0:0-0: Error: unqualified type specified in set definition. Try "typeof expression" instead of "type datatype".
> > > internal:0:0-0: Error: Could not parse symbolic invalid expression
> >
> > Maybe block this from the json parser itself?
>
> Maybe this instead? This covers for empty concatenation in both set
> key and set data.
I don't like the idea of having to keep double-error-checks in
both json and bison frontends.
I would prefer a generic solution where possible, unless
there is some other advantage such as better error reporting.
next prev parent reply other threads:[~2025-03-27 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 11:52 [PATCH nft] evaluate: tolerate empty concatenation Florian Westphal
2025-03-27 15:33 ` Pablo Neira Ayuso
2025-03-27 15:40 ` Pablo Neira Ayuso
2025-03-27 15:49 ` Florian Westphal [this message]
2025-03-27 15:52 ` Pablo Neira Ayuso
2025-03-27 15:55 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327154910.GB21843@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).