From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: Corubba Smith <corubba@gmx.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2 1/2] ulog: remove input plugin
Date: Sat, 29 Mar 2025 15:00:07 +0100 [thread overview]
Message-ID: <20250329140007.GB19898@breakpoint.cc> (raw)
In-Reply-To: <20250329133121.GA19898@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> Corubba Smith <corubba@gmx.de> wrote:
> > The ULOG target was removed from the linux kernel with 7200135bc1e6
> > ("netfilter: kill ulog targets") aka v3.17, so remove the input plugin
> > for it. It's successor NFLOG should be used instead, which has its own
> > input plugin.
>
> Your email client is reformattig parts of the diff:
> % git am ~/Downloads/ulogd2-1-2-ulog-remove-input-plugin.patch
> Applying: ulog: remove input plugin
> error: patch failed: doc/ulogd.sgml:132
> error: doc/ulogd.sgml: patch does not apply
> Patch failed at 0001 ulog: remove input plugin
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
I resolved the conflicts locally and applied the patches, please
double check that I did not miss anything.
> https://patchwork.ozlabs.org/project/netfilter-devel/patch/23db0352-9525-427b-a936-c8ef87e4d5b7@gmx.de/
>
> Can you send the pach to yourself and make sure "git am" can apply it
> again?
FWIW, it looks like something in the delivery path removes trailing
spaces, turning "some line \n" into "some line\n" which will make git-am
fail as intree and diff don't match.
next prev parent reply other threads:[~2025-03-29 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 11:07 [PATCH ulogd2 1/2] ulog: remove input plugin Corubba Smith
2025-03-29 11:08 ` [PATCH ulogd2 2/2] ulogd: remove libipulog Corubba Smith
2025-03-29 13:31 ` [PATCH ulogd2 1/2] ulog: remove input plugin Florian Westphal
2025-03-29 14:00 ` Florian Westphal [this message]
2025-03-30 10:46 ` Corubba Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250329140007.GB19898@breakpoint.cc \
--to=fw@strlen.de \
--cc=corubba@gmx.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).