From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: sontu21@gmail.com, sbrivio@redhat.com, Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet
Date: Fri, 4 Apr 2025 08:20:51 +0200 [thread overview]
Message-ID: <20250404062105.4285-1-fw@strlen.de> (raw)
Sontu Mazumdar reports incorrect matching in the pipapo set type.
First patch adds debug infrastructure (conditional for CONFIG_DEBUG_NET)
to add rudimentary avx register tracking.
Second patch is the actual fix.
Third patch adds a test case.
I checked that selftest passes with all three patches applied,
that the new selftest fails without the fix and that the
register tracking added in patch 1 also produces a WARN splat.
Florian Westphal (3):
nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds
nft_set_pipapo: fix incorrect avx2 match of 5th field octet
selftests: netfilter: add test case for recent mismatch bug
net/netfilter/nft_set_pipapo_avx2.c | 139 +++++++++++++++++-
.../net/netfilter/nft_concat_range.sh | 39 ++++-
2 files changed, 171 insertions(+), 7 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-04 6:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 6:20 Florian Westphal [this message]
2025-04-04 6:20 ` [PATCH nf 1/3] nft_set_pipapo: add avx register usage tracking for NET_DEBUG builds Florian Westphal
2025-04-04 10:40 ` Stefano Brivio
2025-04-04 11:42 ` Florian Westphal
2025-04-04 6:20 ` [PATCH nf 2/3] nft_set_pipapo: fix incorrect avx2 match of 5th field octet Florian Westphal
2025-04-04 8:34 ` Stefano Brivio
2025-04-04 6:20 ` [PATCH nf 3/3] selftests: netfilter: add test case for recent mismatch bug Florian Westphal
2025-04-04 11:51 ` Stefano Brivio
2025-04-09 9:51 ` sontu mazumdar
2025-04-09 10:13 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404062105.4285-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=sontu21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox