From: Jeremy Sowden <jeremy@azazel.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] libnftables: do not re-add default include directory in include search
Date: Thu, 25 Sep 2025 21:00:36 +0100 [thread overview]
Message-ID: <20250925200036.GC6365@celephais.dreamlands> (raw)
In-Reply-To: <20250924222119.191657-1-pablo@netfilter.org>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On 2025-09-25, at 00:21:19 +0200, Pablo Neira Ayuso wrote:
>Otherwise globbing might duplicate included files because
>include_path_glob() is called twice.
>
>Fixes: 7eb950a8e8fa ("libnftables: include canonical path to avoid duplicates")
>Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Tested-by: Jeremy Sowden <jeremy@azazel.net>
LGTM. Will get this into Debian.
Thanks, Pablo.
J.
>---
> src/libnftables.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/src/libnftables.c b/src/libnftables.c
>index c8293f77677f..9f6a1bc33539 100644
>--- a/src/libnftables.c
>+++ b/src/libnftables.c
>@@ -176,6 +176,9 @@ static bool nft_ctx_find_include_path(struct nft_ctx *ctx, const char *path)
> return true;
> }
>
>+ if (!strcmp(path, DEFAULT_INCLUDE_PATH))
>+ return true;
>+
> return false;
> }
>
>--
>2.30.2
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 931 bytes --]
next prev parent reply other threads:[~2025-09-25 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 22:21 [PATCH nft] libnftables: do not re-add default include directory in include search Pablo Neira Ayuso
2025-09-25 20:00 ` Jeremy Sowden [this message]
2025-09-25 21:42 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925200036.GC6365@celephais.dreamlands \
--to=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).