From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
jv@jvosburgh.net, olteanv@gmail.com, jiri@resnulli.us,
mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, kuniyu@google.com, martineau@kernel.org,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
antonio@openvpn.net, allison.henderson@oracle.com,
petrm@nvidia.com, razor@blackwall.org, idosch@nvidia.com,
linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
davem@davemloft.net
Subject: Re: [PATCH net] selftests: net: unify the Makefile formats
Date: Thu, 2 Oct 2025 08:58:07 -0700 [thread overview]
Message-ID: <20251002085807.370bee93@kernel.org> (raw)
In-Reply-To: <138fe27b-7ed1-4065-827c-01e6df483153@kernel.org>
On Thu, 2 Oct 2025 12:48:59 +0200 Matthieu Baerts wrote:
> Strange, I think all other blocks are OK in this patch, except this one:
> the order is the same as before (so not sorted by alphabetical order),
> and the last line is not "# end of TEST_PROGS" as expected.
Well spotted! I typed the comments manually.
The checker was just checking if there's a comment at the end, let me
make it also check that the variable name is correct if the comment
is not empty.
next prev parent reply other threads:[~2025-10-02 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 1:30 [PATCH net] selftests: net: unify the Makefile formats Jakub Kicinski
2025-10-02 10:48 ` Matthieu Baerts
2025-10-02 15:58 ` Jakub Kicinski [this message]
2025-10-02 11:21 ` Antonio Quartulli
2025-10-02 19:23 ` Phil Sutter
2025-10-02 22:03 ` Jakub Kicinski
2025-10-06 11:59 ` Petr Machata
2025-10-02 23:38 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002085807.370bee93@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kadlec@netfilter.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).